Split (1)

train · 7.53k rows

org stringclasses 73 values	repo stringclasses 76 values	number stringlengths 2 5	state stringclasses 1 value	title stringlengths 4 161	body stringlengths 0 63k ⌀	base stringlengths 87 127	resolved_issues stringlengths 2 88k	fix_patch stringlengths 293 14M	test_patch stringlengths 165 88.9M	fixed_tests stringlengths 57 2.27M	p2p_tests stringlengths 2 2.19M	f2p_tests stringlengths 2 78.9k	s2p_tests stringclasses 1 value	n2p_tests stringlengths 2 2.27M	run_result stringlengths 119 1.67M	test_patch_result stringlengths 119 1.66M	fix_patch_result stringlengths 130 1.67M	instance_id stringlengths 12 36 ⌀	language stringclasses 8 values	docker stringlengths 26 50 ⌀
rjsf-team	react-jsonschema-form	4600	closed	Bug: schema references in combinators(allOf, anyOf, oneOf) cannot be modified when defaults were set	### Reasons for making this change Fixes #4555 ### Checklist - [X] I'm adding or updating code - [X] I've added and/or updated tests. I've run `npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update` to update snapshots, if needed. - [ ] I've updated [docs](https://rjsf-team.githu...	{"label": "rjsf-team:main", "ref": "main", "sha": "e6cbaf7643bb74283fa4fa2f47104e0d9ebd6fd1"}	[{"number": 4555, "title": "Cannot modify an anyOf object field when the defaults are set in the schema", "body": "### Prerequisites\n\n- [x] I have searched the existing issues\n- [x] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\n- [x] I have read the [doc...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 043c85b1b2..d81f2f0eb8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ it according to semantic versioning. For example, if your PR adds a breaking cha should change the heading of the (upcoming) version to include a major version bump. --> + # 6.0.0-be...	diff --git a/packages/core/test/Form.test.jsx b/packages/core/test/Form.test.jsx index 8f4b8408b4..5f8709e3dc 100644 --- a/packages/core/test/Form.test.jsx +++ b/packages/core/test/Form.test.jsx @@ -1427,6 +1427,70 @@ describeRepeated('Form common', (createFormComponent) => { 'root_any_of_field_second', ...	{"Client: Compiled successfully in 29.52s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "test/Form.test.jsx": {"run": "PASS", "test": "FAIL", "fix": "PASS"}, "Server: Compiled successfully in 22.35s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Should modify anyOf definition references when the defaults are se...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{"test/Form.test.jsx": {"run": "PASS", "test": "FAIL", "fix": "PASS"}}	{}	{"Client: Compiled successfully in 29.52s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Server: Compiled successfully in 22.35s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Should modify anyOf definition references when the defaults are set.": {"run": "NONE", "test": "NONE", "fix": "PASS"}}	{"passed_count": 1899, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw if the rootSchema is different than the one the validator was constructed with", "should throw when more than one wildcard is present", "has property keys that match patternProperties, additional...	{"passed_count": 1898, "failed_count": 4, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw if the rootSchema is different than the one the validator was constructed with", "should throw when more than one wildcard is present", "has property keys that match patternProperties, additional...	{"passed_count": 1900, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw if the rootSchema is different than the one the validator was constructed with", "should throw when more than one wildcard is present", "has property keys that match patternProperties, additional...	null	ts	null
rjsf-team	react-jsonschema-form	4570	closed	Bug: schema combinators(allOf, anyOf, oneOf) cannot be modified when defaults were set	### Reasons for making this change Fixes #4555 ### Checklist - [X] I'm adding or updating code - [X] I've added and/or updated tests. I've run `npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update` to update snapshots, if needed. - [ ] I've updated [docs](https://rjsf-team.gi...	{"label": "rjsf-team:main", "ref": "main", "sha": "2704547e0ff4e772232268081a4cdd0b8bcae7a2"}	[{"number": 4555, "title": "Cannot modify an anyOf object field when the defaults are set in the schema", "body": "### Prerequisites\n\n- [x] I have searched the existing issues\n- [x] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\n- [x] I have read the [doc...	diff --git a/CHANGELOG.md b/CHANGELOG.md index c52a964bda..fd72039559 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,10 @@ should change the heading of the (upcoming) version to include a major version b - Fixed issue in BaseInputTemplate where input props were passed to `slotProps.htmlInput`, which does ...	diff --git a/packages/core/test/Form.test.jsx b/packages/core/test/Form.test.jsx index e1e5cc1f33..8f76fcd45e 100644 --- a/packages/core/test/Form.test.jsx +++ b/packages/core/test/Form.test.jsx @@ -1261,6 +1261,174 @@ describeRepeated('Form common', (createFormComponent) => { sinon.assert.callCount(onChange, 1)...	{"addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should throw if the rootSchema is different than the one the validator was constructed with": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "f...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should fill array with additional items ...	{}	{}	{"addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should throw if the rootSchema is different than the one the validator was constructed with": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "f...	{"passed_count": 1599, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	{"passed_count": 1509, "failed_count": 3, "skipped_count": 0, "passed_tests": ["should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWidget", "should correctly guess t...	{"passed_count": 1606, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	null	ts	null
rjsf-team	react-jsonschema-form	4499	closed	Bug: Custom validate errors are not cleared when the form is valid	### Reasons for making this change Fixes #4365 ### Checklist - [X] I'm adding or updating code - [X] I've added and/or updated tests. I've run `npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update` to update snapshots, if needed. - [ ] I've updated [docs](https://rjsf-team.githu...	{"label": "rjsf-team:main", "ref": "main", "sha": "1238e0afc093a073700ade705435c7f00fcaa11d"}	[{"number": 4365, "title": "Custom validation error doesn't hide on good result", "body": "### Prerequisites\n\n- [X] I have searched the existing issues\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\n- [X] I have read the [documentation](https://rjsf...	diff --git a/CHANGELOG.md b/CHANGELOG.md index b819d00e67..87d27f4e91 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,12 @@ it according to semantic versioning. For example, if your PR adds a breaking cha should change the heading of the (upcoming) version to include a major version bump. --> +# 5.24.4 + ...	diff --git a/packages/core/test/Form.test.jsx b/packages/core/test/Form.test.jsx index b774049fd9..e1e5cc1f33 100644 --- a/packages/core/test/Form.test.jsx +++ b/packages/core/test/Form.test.jsx @@ -2671,6 +2671,82 @@ describeRepeated('Form common', (createFormComponent) => { ); }); }); + + desc...	{"should throw if the rootSchema is different than the one the validator was constructed with": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "descriptionLocation tooltip in formContext": {"run": "PASS", "tes...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"should throw if the rootSchema is different than the one the validator was constructed with": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "descriptionLocation tooltip in formContext": {"run": "PASS", "tes...	{"passed_count": 1596, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	{"passed_count": 1537, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	{"passed_count": 1597, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	null	ts	null
rjsf-team	react-jsonschema-form	4457	closed	Bug: File accept attribute not working on mui and chakra-ui.	### Reasons for making this change Fixes #4404 ### Checklist - [X] I'm adding or updating code - [X] I've added and/or updated tests. I've run `npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update` to update snapshots, if needed. - [ ] I've updated [docs](https://rjsf-team.githu...	{"label": "rjsf-team:main", "ref": "main", "sha": "2b5c90743f9cf55c9e6b8ddf7b2fa025d9607f8c"}	[{"number": 4404, "title": "File 'accept' Attribute Not Functioning", "body": "### Prerequisites\r\n\r\n- [X] I have searched the existing issues\r\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\r\n- [X] I have read the [documentation](https://rjsf-tea...	diff --git a/CHANGELOG.md b/CHANGELOG.md index e0be4c35b7..358c85bcc9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,11 @@ should change the heading of the (upcoming) version to include a major version b ## @rjsf/utils - switch `lodash.isEqualWith` to `fast-equals.createCustomEqual` providing `areFunctio...	diff --git a/packages/utils/test/getInputProps.test.ts b/packages/utils/test/getInputProps.test.ts index 8708083730..0ad15f22f9 100644 --- a/packages/utils/test/getInputProps.test.ts +++ b/packages/utils/test/getInputProps.test.ts @@ -1,16 +1,23 @@ -import { getInputProps, RJSFSchema } from '../src'; +import { getInput...	{"addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should throw if the rootSchema is different than the one the validator was constructed with": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "f...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should fill array with additional items ...	{}	{}	{"addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should throw if the rootSchema is different than the one the validator was constructed with": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "f...	{"passed_count": 1614, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	{"passed_count": 1522, "failed_count": 2, "skipped_count": 0, "passed_tests": ["should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWidget", "should correctly guess t...	{"passed_count": 1615, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	null	ts	null
rjsf-team	react-jsonschema-form	4429	closed	fix: formData change clear errorMessage	### Reasons for making this change fixes #4426 If this is related to existing tickets, include links to them as well. Use the syntax `fixes #[issue number]` (ex: `fixes #123`). If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.g...	{"label": "rjsf-team:main", "ref": "main", "sha": "a521990c251a36df480747edddbb477064df02de"}	[{"number": 4426, "title": "The errorMessage will not be cleared after the controlled Form formData changes", "body": "### Prerequisites\n\n- [X] I have searched the existing issues\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\n- [X] I have read the ...	diff --git a/CHANGELOG.md b/CHANGELOG.md index aecd576993..e19fd1020f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,14 +18,16 @@ should change the heading of the (upcoming) version to include a major version b # 5.24.0 -## @rjsf/core +## @rjsf/core - Fixed issue with schema if/then/else conditions where ...	diff --git a/packages/core/test/Form.test.jsx b/packages/core/test/Form.test.jsx index 52eb0128eb..b774049fd9 100644 --- a/packages/core/test/Form.test.jsx +++ b/packages/core/test/Form.test.jsx @@ -4489,8 +4489,8 @@ describe('Form omitExtraData and liveOmit', () => { // // error should still be present. ...	{"should render text input for each array item": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should set attr action of form": {"run": "PASS", "test": "NONE",...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should fill array with additional items schema when items is empty": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should allow complete exponential numbers": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "sho...	{}	{}	{"should render text input for each array item": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should set attr action of form": {"run": "PASS", "test": "NONE",...	{"passed_count": 1598, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	{"passed_count": 662, "failed_count": 0, "skipped_count": 0, "passed_tests": ["should throw if the body is not a valid dataURI", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should concat nested arrays under `required` keyword", "should fill array with addit...	{"passed_count": 1608, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	null	ts	null
rjsf-team	react-jsonschema-form	4413	closed	fix: Short-circuit File and Date constructor access in isObject	### Reasons for making this change This change refactors `isObject` to significantly reduce the frequency of accesses to `File` and `Date` by short-circuiting the function with several simple checks prior to running `instanceof` checks involving the two native classes. The motivation for making this change is explai...	{"label": "rjsf-team:main", "ref": "main", "sha": "4359bd16e29d2c2f464373568f3e80ab2e8027fe"}	[{"number": 4409, "title": "Performance hit from isObject when updating Form value within qiankun microapp", "body": "### Prerequisites\r\n\r\n- [X] I have searched the existing issues\r\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\r\n- [X] I have re...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 453e899d1e..b014249c06 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,10 @@ should change the heading of the (upcoming) version to include a major version b - Fix default value population when switching between options in `MultiSchemaField` [#4375](https://gi...	diff --git a/packages/utils/test/isObject.test.ts b/packages/utils/test/isObject.test.ts index b1e6197cea..6926ccd6a2 100644 --- a/packages/utils/test/isObject.test.ts +++ b/packages/utils/test/isObject.test.ts @@ -26,4 +26,38 @@ describe('isObject()', () => { expect(isObject(object)).toBe(true); }); });...	{"addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should throw if the rootSchema is different than the one the validator was constructed with": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "f...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should fill array with additional items ...	{}	{}	{"addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should throw if the rootSchema is different than the one the validator was constructed with": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "f...	{"passed_count": 1583, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	{"passed_count": 1497, "failed_count": 2, "skipped_count": 0, "passed_tests": ["should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWidget", "should correctly guess t...	{"passed_count": 1583, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	null	ts	null
rjsf-team	react-jsonschema-form	4398	closed	Fix issue where ui:title in anyOf/oneOf is not shown in error messages	### Reasons for making this change Fixed issue where `ui:title` in `anyOf`/`oneOf` is not shown in error messages. This fixes #4368 with the following limitations. 1. This is only applicable in the case `missingProperty` exists. 2. As `schemaPath` is not stable (see [ajv-validator/ajv#512](https://github.com/...	{"label": "rjsf-team:main", "ref": "main", "sha": "433f99ba43c46a95163f44de31b2dd7d7db62f94"}	[{"number": 4368, "title": "Validation error messages not using `ui:title` in `anyOf` option field errors with external validation", "body": "### Prerequisites\n\n- [X] I have searched the existing issues\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\...	diff --git a/CHANGELOG.md b/CHANGELOG.md index ffdce1c64c..453e899d1e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,10 @@ should change the heading of the (upcoming) version to include a major version b - Fix default value population when switching between options in `MultiSchemaField` [#4375](https://gi...	diff --git a/packages/validator-ajv8/test/validator.test.ts b/packages/validator-ajv8/test/validator.test.ts index 2688cd6c6c..2ce40017a7 100644 --- a/packages/validator-ajv8/test/validator.test.ts +++ b/packages/validator-ajv8/test/validator.test.ts @@ -1344,6 +1344,247 @@ describe('AJV8Validator', () => { ...	{"should successfully create a base64 object and encode/decode string in browser": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should successfully create a base64 object and encode/decode string in node.js": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "semantic props if passed should overwrite defaultSchemaPro...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"should successfully create a base64 object and encode/decode string in browser": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should successfully create a base64 object and encode/decode string in node.js": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "semantic props if passed should overwrite defaultSchemaPro...	{"passed_count": 1583, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	{"passed_count": 1566, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	{"passed_count": 1583, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	null	ts	null
rjsf-team	react-jsonschema-form	4349	closed	fix: Validation error messages are inconsistent #4348	### Reasons for making this change - Replaced message field with property `schema title` or `ui:title` correctly - Fixes #4348 ### Images - Before ![image](https://github.com/user-attachments/assets/97a03762-e7ec-408e-8f1c-8fcac93a5757) - After ![image](https://github.com/user-attachments/assets/7634e5ac-e...	{"label": "rjsf-team:main", "ref": "main", "sha": "d7bd13073cee37db89ba60fc2238813d47b9dbc9"}	[{"number": 4348, "title": "Validation error messages are inconsistent", "body": "### Prerequisites\n\n- [X] I have searched the existing issues\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\n- [X] I have read the [documentation](https://rjsf-team.git...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 2ec580441b..ef6f0094ec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,10 @@ should change the heading of the (upcoming) version to include a major version b - Fixed validation regression Form not revalidating after formData change, fixing [#4343](https://gith...	diff --git a/packages/validator-ajv8/test/validator.test.ts b/packages/validator-ajv8/test/validator.test.ts index cab924497b..ea774d33a1 100644 --- a/packages/validator-ajv8/test/validator.test.ts +++ b/packages/validator-ajv8/test/validator.test.ts @@ -1401,6 +1401,67 @@ describe('AJV8Validator', () => { ...	{"should successfully create a base64 object and encode/decode string in browser": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should successfully create a base64 object and encode/decode string in node.js": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "semantic props if passed should overwrite defaultSchemaPro...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"should successfully create a base64 object and encode/decode string in browser": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should successfully create a base64 object and encode/decode string in node.js": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "semantic props if passed should overwrite defaultSchemaPro...	{"passed_count": 1566, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	{"passed_count": 1549, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	{"passed_count": 1566, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	null	ts	null
rjsf-team	react-jsonschema-form	4313	closed	feat: fixes #4297 Support array numbers in pathOfError for ErrorSchemaBuilder	### Reasons for making this change fixes [#4297](https://github.com/rjsf-team/react-jsonschema-form/issues/4297) Using ErrorSchemaBuilder to add errors to arrays results in the wrong format being generated. This PR extends the ErrorSchemaBuilder to support adding, setting and clearing errors that have an array num...	{"label": "rjsf-team:main", "ref": "main", "sha": "f92f9f6f8590fc057e1141eac9fe176e87be3fb6"}	[{"number": 4297, "title": "ToErrorList doesn't return array errors", "body": "### Prerequisites\r\n\r\n- [X] I have searched the existing issues\r\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\r\n- [X] I have read the [documentation](https://rjsf-tea...	diff --git a/packages/docs/docs/api-reference/utility-functions.md b/packages/docs/docs/api-reference/utility-functions.md index 1e6a9812ff..79935921bb 100644 --- a/packages/docs/docs/api-reference/utility-functions.md +++ b/packages/docs/docs/api-reference/utility-functions.md @@ -1172,7 +1172,7 @@ For more informatio...	diff --git a/packages/utils/test/ErrorSchemaBuilder.test.ts b/packages/utils/test/ErrorSchemaBuilder.test.ts index 09a587020d..54d587e0b1 100644 --- a/packages/utils/test/ErrorSchemaBuilder.test.ts +++ b/packages/utils/test/ErrorSchemaBuilder.test.ts @@ -153,6 +153,90 @@ describe('ErrorSchemaBuilder', () => { ...	{"should render text input for each array item": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should set attr action of form": {"run": "PASS", "test": "NONE",...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should fill array with additional items schema when items is empty": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should allow complete exponential numbers": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "sho...	{}	{}	{"should render text input for each array item": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should set attr action of form": {"run": "PASS", "test": "NONE",...	{"passed_count": 1550, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	{"passed_count": 621, "failed_count": 0, "skipped_count": 0, "passed_tests": ["should throw if the body is not a valid dataURI", "should concat nested arrays under `required` keyword", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should fill array with addit...	{"passed_count": 1553, "failed_count": 2, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should throw if the rootSchema is different than the one the validator was constructed with", "should render a root custom widget", "should submit defaul...	null	ts	null
rjsf-team	react-jsonschema-form	3655	closed	fix: Remove duplicate title for SelectWidget and description for CheckboxWidget	### Reasons for making this change Fixes #3594 - Updated `@rjsf/antd` to remove the duplicate title for `SelectWidget` and description for `CheckboxWidget` - Updated the snapshots due to the changes made above - Updated the `CHANGELOG.md` accordinglt ### Checklist - [ ] I'm updating documentation - [...	{"label": "rjsf-team:main", "ref": "main", "sha": "3186c39130b5a35ce655cfd14c9cf4aeda7b1948"}	[{"number": 3594, "title": "Antd theme: repeated title for select widget", "body": "### Prerequisites\n\n- [X] I have searched the existing issues\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\n- [X] I have read the [documentation](https://rjsf-team.g...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 785b6b3ec0..a00dcdc2d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ should change the heading of the (upcoming) version to include a major version b ## @rjsf/antd - Fix [#3608](https://github.com/rjsf-team/react-jsonschema-form/issues/3608) by ensurin...	diff --git a/packages/antd/test/__snapshots__/Array.test.tsx.snap b/packages/antd/test/__snapshots__/Array.test.tsx.snap index dfa4b9ff37..2668292dcf 100644 --- a/packages/antd/test/__snapshots__/Array.test.tsx.snap +++ b/packages/antd/test/__snapshots__/Array.test.tsx.snap @@ -2530,14 +2530,6 @@ exports[`with title an...	{"Creating entry file 1.1 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 31.6 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 7.5 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 32.9 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Clien...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"Creating entry file 1.1 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 31.6 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 7.5 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 32.9 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Clien...	{"passed_count": 1315, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	{"passed_count": 1311, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	{"passed_count": 1311, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	null	ts	null
rjsf-team	react-jsonschema-form	3626	closed	Add additionalProperties support to fluent-ui theme	### Reasons for making this change Additional properties should be handled in the fluent-ui theme equivalently to how they are handled in the other themes. - Adds "Add Item" button to objects that support additional properties. - Adds editable key and a remove button to additional properties. - Fixes #2777. ...	{"label": "rjsf-team:main", "ref": "main", "sha": "24cd2bc64fe032f59eaee16ad01e0e605ff965fe"}	[{"number": 2777, "title": "AdditionalProperties are not supported in FluentUI template", "body": "### Prerequisites\r\n\r\n- [x] I have read the [documentation](https://react-jsonschema-form.readthedocs.io/);\r\n- [x] In the case of a bug report, I understand that providing a [SSCCE](http://sscce.org/) example is trem...	diff --git a/CHANGELOG.md b/CHANGELOG.md index f136f4dd19..d058ef2240 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,10 @@ should change the heading of the (upcoming) version to include a major version b - Fix [#3608](https://github.com/rjsf-team/react-jsonschema-form/issues/3608) by ensuring the root fie...	diff --git a/packages/fluent-ui/test/__snapshots__/Array.test.tsx.snap b/packages/fluent-ui/test/__snapshots__/Array.test.tsx.snap index 8ec9849c9e..926eaf3cdd 100644 --- a/packages/fluent-ui/test/__snapshots__/Array.test.tsx.snap +++ b/packages/fluent-ui/test/__snapshots__/Array.test.tsx.snap @@ -8,10 +8,8 @@ exports[...	{"Creating entry file 1.5 secs": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Client: Compiled successfully in 15.79s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Creating entry file 1.1 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 34.6 secs": {"run": "NONE", "test": "NONE", "fix":...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"Creating entry file 1.5 secs": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Client: Compiled successfully in 15.79s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Creating entry file 1.1 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 34.6 secs": {"run": "NONE", "test": "NONE", "fix":...	{"passed_count": 1264, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	{"passed_count": 1264, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	{"passed_count": 1265, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	null	ts	null
rjsf-team	react-jsonschema-form	3621	closed	Fix #3608 by removing ternary and ensuring AntD FieldTemplate wraps root in `Form.Item`	- Ensure the root field is always wrapped in Form.Item The original ternary expression has existed since the antd theme was added in #1561. I am not familiar enough with antd to know what, if any, undesirable effects this change could cause. I looked at most of the playground examples and did not notice any new issu...	{"label": "rjsf-team:main", "ref": "main", "sha": "436493b7641c02f4030537d09628f3c41239dad1"}	[{"number": 3608, "title": "Error message not showing", "body": "### Prerequisites\r\n\r\n- [X] I have searched the existing issues\r\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\r\n- [X] I have read the [documentation](https://rjsf-team.github.io/re...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 7fe937d639..f136f4dd19 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,12 @@ should change the heading of the (upcoming) version to include a major version b --> +# 5.6.3 + +## @rjsf/antd + +- Fix [#3608](https://github.com/rjsf-team/react-jsonschema-form/is...	diff --git a/packages/antd/test/__snapshots__/Array.test.tsx.snap b/packages/antd/test/__snapshots__/Array.test.tsx.snap index e3a6192ec0..dfa4b9ff37 100644 --- a/packages/antd/test/__snapshots__/Array.test.tsx.snap +++ b/packages/antd/test/__snapshots__/Array.test.tsx.snap @@ -9,92 +9,114 @@ exports[`array fields arra...	{"descriptionLocation tooltip in formContext": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Building modules 8.7 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Server: Compiled successfully in 19.46s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Creating entry file 1.6 secs": {"run": "PASS", "test": "...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"descriptionLocation tooltip in formContext": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Building modules 8.7 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Server: Compiled successfully in 19.46s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Creating entry file 1.6 secs": {"run": "PASS", "test": "...	{"passed_count": 1266, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	{"passed_count": 1262, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	{"passed_count": 1264, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	null	ts	null
rjsf-team	react-jsonschema-form	3583	closed	fix: Fixes broken playground form display and small mui bug	### Reasons for making this change Fixes #3576 and #3579 by only passing `templates` with non-`undefined` values Fixes #3578 by using `TextField` to render the label key input value - Updated `@rjsf/material-ui` and `@rjsf/mui` to use the `TextField` as the input for the label key value rather than attempting to...	{"label": "rjsf-team:main", "ref": "main", "sha": "a17790c80692e5c48f9265ace3007f4e9047aabf"}	[{"number": 3578, "title": "MUI 5 Input border is interrupting with label", "body": "### Prerequisites\r\n\r\n- [X] I have searched the existing issues\r\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\r\n- [X] I have read the [documentation](https://rj...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 73d0692579..6ed155421b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,12 +16,28 @@ should change the heading of the (upcoming) version to include a major version b --> +# 5.5.2 + +## @rjsf/material-ui + +- Switched to using `TextField` for the `WrapIfAdditionalTe...	diff --git a/packages/material-ui/test/__snapshots__/Object.test.tsx.snap b/packages/material-ui/test/__snapshots__/Object.test.tsx.snap index c1fac464d7..e09a2ee46e 100644 --- a/packages/material-ui/test/__snapshots__/Object.test.tsx.snap +++ b/packages/material-ui/test/__snapshots__/Object.test.tsx.snap @@ -36,20 +36...	{"Building modules 51.6 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 50.7 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 1.4 mins": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Building modules 1.6 mins": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Creating...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"Building modules 51.6 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 50.7 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 1.4 mins": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Building modules 1.6 mins": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Creating...	{"passed_count": 1249, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	{"passed_count": 1248, "failed_count": 6, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	{"passed_count": 1250, "failed_count": 5, "skipped_count": 0, "passed_tests": ["addFormat() was called twice", "should throw when more than one wildcard is present", "should render a root custom widget", "should submit defaults when they are defined in a nested additionalProperties", "should render customized AltDateWi...	null	ts	null
rjsf-team	react-jsonschema-form	3521	closed	fix: Fixed 3478 and 3520 by updating documentation	### Reasons for making this change Fixes #3478 and #3520 by updating documentation - Updated the root `package.json` to change `npm start` to documentation about the new process - Updated the `package.json` files to remove the `npm start` script in all packages that had them except for `playground` and `docs` -...	{"label": "rjsf-team:main", "ref": "main", "sha": "12b7df1ea9d0a18a0bb51bf802c210ebe69c2233"}	[{"number": 3478, "title": "Playground fails to launch from repo root", "body": "### Prerequisites\n\n- [X] I have searched the existing issues\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\n- [X] I have read the [documentation](https://rjsf-team.gith...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 249fa3b020..54c1195913 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,25 @@ should change the heading of the (upcoming) version to include a major version b - Updated `AltDateWidget` to remove an infinite loop caused by two conflicting effects by merging them...	diff --git a/packages/utils/test/schema.test.ts b/packages/utils/test/schema.test.ts index 2f1d1c81d6..cb2b33f55a 100644 --- a/packages/utils/test/schema.test.ts +++ b/packages/utils/test/schema.test.ts @@ -16,6 +16,7 @@ import { const testValidator = getTestValidator({}); +// NOTE: to restrict which tests to run,...	{"Server: Compiled successfully in 21.15s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Creating entry file 1.8 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Client: Compiled successfully in 18.02s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 53 secs": {"run": "NONE", "test": "NONE...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"Server: Compiled successfully in 21.15s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Creating entry file 1.8 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Client: Compiled successfully in 18.02s": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 53 secs": {"run": "NONE", "test": "NONE...	{"passed_count": 1219, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should concat nested arrays under `required` keyword", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should render text input for each array item", "addFormat() was called twice",...	{"passed_count": 1219, "failed_count": 5, "skipped_count": 0, "passed_tests": ["returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should concat nested arrays under `required` keyword", "should render text input for each array item", "addFormat() was called twice",...	{"passed_count": 1220, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should concat nested arrays under `required` keyword", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should render text input for each array item", "addFormat() was called twice",...	null	ts	null
rjsf-team	react-jsonschema-form	3379	closed	fix: Cast the value as an Array in CheckboxesWidget	### Reasons for making this change Fixes #2141 by reimplementing #2142 for all themes but `antd` When the value passed to the `CheckboxesWidget` was a single value rather than an array, things would break in the control - Updated the `CheckboxesWidget` in all themes but `antd` (which uses simpler logic) to fix e...	{"label": "rjsf-team:main", "ref": "main", "sha": "5db71e39d1a68f76393690b27d63c7c8b28d7312"}	[{"number": 2141, "title": "CheckboxesWidget should ensure that the value is an Array", "body": "### Prerequisites\r\n\r\n- [x] I have read the [documentation](https://react-jsonschema-form.readthedocs.io/);\r\n- [x] In the case of a bug report, I understand that providing a [SSCCE](http://sscce.org/) example is tremen...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 0910098483..36245b6173 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,31 +23,39 @@ should change the heading of the (upcoming) version to include a major version b ## @rjsf/bootstrap-4 - Added support for new `style` prop on `FieldTemplate` and `WrapIfAdditionalTe...	diff --git a/packages/bootstrap-4/test/__snapshots__/CheckboxesWidget.test.tsx.snap b/packages/bootstrap-4/test/__snapshots__/CheckboxesWidget.test.tsx.snap index 92d3fb4df5..1928973404 100644 --- a/packages/bootstrap-4/test/__snapshots__/CheckboxesWidget.test.tsx.snap +++ b/packages/bootstrap-4/test/__snapshots__/Chec...	{"should render text input for each array item": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should set attr action of form": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should throw when more than one wildcard is present": {"run": ...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should fill array with additional items schema when items is empty": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should allow com...	{}	{}	{"should render text input for each array item": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should set attr action of form": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should throw when more than one wildcard is present": {"run": ...	{"passed_count": 1078, "failed_count": 5, "skipped_count": 0, "passed_tests": ["returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should concat nested arrays under `required` keyword", "should render text input for each array item", "addFormat() was called twice",...	{"passed_count": 387, "failed_count": 0, "skipped_count": 0, "passed_tests": ["returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should concat nested arrays under `required` keyword", "addFormat() was called twice", "should fill array with additional items schema ...	{"passed_count": 1087, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should concat nested arrays under `required` keyword", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should render text input for each array item", "addFormat() was called twice",...	null	ts	null
rjsf-team	react-jsonschema-form	3337	closed	Fix: Better validation messages using schema/uiSchema title if it exists	### Reasons for making this change Fixes #3246 by reimplementing #2634 - The ajv8 `ErrorObject` message is enhanced by replacing the error message field with either the `uiSchema`'s `ui:title` field if one exists or the `parentSchema` title if one exists. ### Checklist * [ ] I'm updating documentation ...	{"label": "rjsf-team:main", "ref": "main", "sha": "b24280462749db561108ffb648d16dfc3120dea5"}	[{"number": 3246, "title": "Is it possible to display field titles in validation error messages instead of real field names?", "body": "### Prerequisites\n\n- [X] I have read the [documentation](https://react-jsonschema-form.readthedocs.io/)\n\n### What theme are you using?\n\ncore\n\n### What is your question?\n\nIs i...	diff --git a/CHANGELOG.md b/CHANGELOG.md index f5d89da1c8..bb3c6335c5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,6 +22,7 @@ should change the heading of the (upcoming) version to include a major version b ## @rjsf/validator-ajv8 - Remove alias for ajv -> ajv8 in package.json. This fixes [#3215](https://git...	diff --git a/packages/validator-ajv8/test/validator.test.ts b/packages/validator-ajv8/test/validator.test.ts index 95ba74e207..5ce32c0c75 100644 --- a/packages/validator-ajv8/test/validator.test.ts +++ b/packages/validator-ajv8/test/validator.test.ts @@ -1,3 +1,4 @@ +import { ErrorObject } from "ajv"; import Ajv2019 f...	{"empty errors array": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Building modules 46.2 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "hidden label": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "number field 0": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "format date": {"run": "PASS", "test": "N...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"empty errors array": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Building modules 46.2 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "hidden label": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "number field 0": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "format date": {"run": "PASS", "test": "N...	{"passed_count": 1076, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should concat nested arrays under `required` keyword", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should render text input for each array item", "addFormat() was called twice",...	{"passed_count": 1037, "failed_count": 5, "skipped_count": 0, "passed_tests": ["returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should concat nested arrays under `required` keyword", "should render text input for each array item", "addFormat() was called twice",...	{"passed_count": 1077, "failed_count": 5, "skipped_count": 0, "passed_tests": ["returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should concat nested arrays under `required` keyword", "should render text input for each array item", "addFormat() was called twice",...	null	ts	null
rjsf-team	react-jsonschema-form	3306	closed	fix: label for checkbox widget	### Reasons for making this change fixes #3302 ### Checklist * [ ] I'm updating documentation - [ ] I've [checked the rendering](https://react-jsonschema-form.readthedocs.io/en/latest/#contributing) of the Markdown text I've added * [X] I'm adding or updating code - [ ] I've added and/or updated...	{"label": "rjsf-team:main", "ref": "main", "sha": "ff034df8f6b7080bf76b7f25e0b1f400fbc818e5"}	[{"number": 3302, "title": "Boolean/Checkbox missing Title in Semantic-ui", "body": "### Prerequisites\n\n- [X] I have searched the existing issues\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\n- [X] I have read the [documentation](https://react-json...	diff --git a/CHANGELOG.md b/CHANGELOG.md index b594f05f06..36a54e1f9a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,8 @@ should change the heading of the (upcoming) version to include a major version b --> # 5.0.0-beta-15 +## @rjsf/semantic-ui +- Fix CheckboxWidget missing label [#3302](https://github.c...	diff --git a/packages/antd/test/Form.test.tsx b/packages/antd/test/Form.test.tsx index da30a2d38f..649c70d3e3 100644 --- a/packages/antd/test/Form.test.tsx +++ b/packages/antd/test/Form.test.tsx @@ -183,9 +183,10 @@ describe("single fields", () => { .toJSON(); expect(tree).toMatchSnapshot(); }); - test(...	{"addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should return an error list": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should return an errorSchema": {"run": "PASS", "t...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should fill array with additional items ...	{}	{}	{"addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should return an error list": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should return an errorSchema": {"run": "PASS", "t...	{"passed_count": 1072, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "addFormat() was called twice", "should validate a simple...	{"passed_count": 1031, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "should concat nested arrays under `required` keyword", "...	{"passed_count": 1072, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should concat nested arrays under `required` keyword", "addFormat() was called twice", "should validate a simple array", "returns type=number, step=multipleOf, ma...	null	ts	null
rjsf-team	react-jsonschema-form	3234	closed	fix(#3233): fix rendering 0 when there are no errors.	### Reasons for making this change fixes #3233 ### Checklist * [ ] I'm updating documentation - [ ] I've [checked the rendering](https://react-jsonschema-form.readthedocs.io/en/latest/#contributing) of the Markdown text I've added * [ ] I'm adding or updating code - [ ] I've added and/or updated...	{"label": "rjsf-team:main", "ref": "main", "sha": "00062d5f0e4c34518e2676743a49201702261828"}	[{"number": 3233, "title": "Rendering `0` for fields when there are no errors after adding a custom validator", "body": "### Prerequisites\n\n- [X] I have searched the existing issues\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\n- [X] I have read th...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c8452c0ce..56780b1873 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,9 @@ should change the heading of the (upcoming) version to include a major version b - For JSON Schemas with `$id`s, use a pre-compiled Ajv validation function when available. - No longer f...	diff --git a/packages/antd/test/__snapshots__/Array.test.tsx.snap b/packages/antd/test/__snapshots__/Array.test.tsx.snap index 40513b922b..1bb419e642 100644 --- a/packages/antd/test/__snapshots__/Array.test.tsx.snap +++ b/packages/antd/test/__snapshots__/Array.test.tsx.snap @@ -745,7 +745,7 @@ exports[`array fields emp...	{"should render text input for each array item": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{"hidden label": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "Creating entry file 1.5 secs": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "number field 0": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "format date": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "Creating entry file 1.7 secs": {"run": "NONE"...	{}	{}	{"should render text input for each array item": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{"passed_count": 1046, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "addFormat() was called twice", "should validate a simple...	{"passed_count": 52, "failed_count": 0, "skipped_count": 0, "passed_tests": ["Creating entry file 1.4 secs", "string field with placeholder", "null field", "password field", "Building modules 11.9 secs", "textarea field", "up/down field", "Building modules 1.3 mins", "format color", "array", "format date", "Building mo...	{"passed_count": 1043, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should concat nested arrays under `required` keyword", "addFormat() was called twice", "should validate a simple array", "returns type=number, step=multipleOf, ma...	null	ts	null
rjsf-team	react-jsonschema-form	3227	closed	Fix incorrect allOf merging (fix #2923) (Reimplement #3025)	See #3025 for more information. It's currently hard to verify the issue in the playground because the examples seem to trigger an infinite loop of some sort that crash the page. Fixes #2923 ### Checklist * [ ] I'm updating documentation - [ ] I've [checked the rendering](https://react-jsonschema-form...	{"label": "rjsf-team:main", "ref": "main", "sha": "68db429c0b2997ac074eaad79cf2bb99af59f1cc"}	[{"number": 2923, "title": "Wrong allOf behaviour", "body": "### Prerequisites\r\n\r\n- [X] I have searched the existing issues\r\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\r\n- [X] I have read the [documentation](https://react-jsonschema-form.read...	diff --git a/CHANGELOG.md b/CHANGELOG.md index d25d85ee16..0826d50c71 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,12 +17,13 @@ should change the heading of the (upcoming) version to include a major version b --> # 5.0.0-beta-15 -# @rjsf/core +## @rjsf/core - Pass the `schema` along to the `ArrayFieldItemTe...	diff --git a/packages/utils/test/schema/getDefaultFormStateTest.ts b/packages/utils/test/schema/getDefaultFormStateTest.ts index aabd14fd84..beb887b34e 100644 --- a/packages/utils/test/schema/getDefaultFormStateTest.ts +++ b/packages/utils/test/schema/getDefaultFormStateTest.ts @@ -151,6 +151,24 @@ export default funct...	{"expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Building modules 13.8 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 1.1 mins": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect addFormats to be called with the new ajv insta...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"expect a new Ajv2019 to be constructed with the AJV_CONFIG": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Building modules 13.8 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 1.1 mins": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "expect addFormats to be called with the new ajv insta...	{"passed_count": 1056, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "addFormat() was called twice", "should validate a simple...	{"passed_count": 1043, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "addFormat() was called twice", "should validate a simple...	{"passed_count": 1055, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "addFormat() was called twice", "should validate a simple...	null	ts	null
rjsf-team	react-jsonschema-form	3200	closed	fix: Partially fix #3189	### Reasons for making this change Partially fix #3189 by allowing for changing the type of the `schema` via a new generic `S` - Updated `@rjsf/utils` to make the `schema` and `rootSchema` props use a new generic type `S` - Added the new `StrictRJSFSchema` type as the alias to `JSON7Schema` changing `RJSFSchem...	{"label": "rjsf-team:main", "ref": "main", "sha": "27a8c70aee11b2a898c828631a68d1d2b66db18c"}	[{"number": 3189, "title": "Support for dependentSchemas and dependentRequired", "body": "### Prerequisites\n\n- [X] I have read the [documentation](https://react-jsonschema-form.readthedocs.io/)\n\n### What theme are you using?\n\ncore\n\n### Is your feature request related to a problem? Please describe.\n\nPer [json-...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 3907c9fe83..ac0549d27b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,24 @@ should change the heading of the (upcoming) version to include a major version b ## @rjsf/chakra-ui - Automatically close single-choice Select widget on selection +## @rjsf/core +- A...	diff --git a/packages/utils/test/getTemplate.test.ts b/packages/utils/test/getTemplate.test.ts index 69ef9199e8..f503ed546f 100644 --- a/packages/utils/test/getTemplate.test.ts +++ b/packages/utils/test/getTemplate.test.ts @@ -1,6 +1,7 @@ import { createSchemaUtils, getTemplate, + RJSFSchema, Registry, Te...	{"Building modules 59.3 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 1.1 mins": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "6312 modules transformed.": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 1.4 mins": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Building ...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{}	{}	{"Building modules 59.3 secs": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 1.1 mins": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "6312 modules transformed.": {"run": "NONE", "test": "NONE", "fix": "PASS"}, "Building modules 1.4 mins": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "Building ...	{"passed_count": 1042, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should concat nested arrays under `required` keyword", "addFormat() was called twice", "should validate a simple array", "returns type=number, step=multipleOf, ma...	{"passed_count": 1039, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should concat nested arrays under `required` keyword", "addFormat() was called twice", "should validate a simple array", "returns type=number, step=multipleOf, ma...	{"passed_count": 1040, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should concat nested arrays under `required` keyword", "addFormat() was called twice", "should validate a simple array", "returns type=number, step=multipleOf, ma...	null	ts	null
rjsf-team	react-jsonschema-form	3187	closed	Fix #3174 by not rendering empty help and extra information for fields	### Reasons for making this change Fixed #3174 - Updated `FieldTemplate` to ensure that `help` and `extra` information is only rendered when the `rawDescription` and `rawErrors` are not provided - Before, even though `description` and `errors` would render empty components, it would still cause unnecessary white...	{"label": "rjsf-team:main", "ref": "main", "sha": "848056e0e7f6756c5e1be4efc4815897542d38c6"}	[{"number": 3174, "title": "Antd theme empty space", "body": "### Prerequisites\n\n- [X] I have searched the existing issues\n- [X] I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the maintainers.\n- [X] I have read the [documentation](https://react-jsonschema-form.readthedocs...	diff --git a/CHANGELOG.md b/CHANGELOG.md index e99f4e39ce..045d73da29 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,9 @@ should change the heading of the (upcoming) version to include a major version b --> # 5.0.0-beta.11 +## @rjsf/antd +- Updated `FieldTemplate` to no longer render additional, unnecess...	diff --git a/packages/antd/test/__snapshots__/Array.test.tsx.snap b/packages/antd/test/__snapshots__/Array.test.tsx.snap index 9f5e8fb7b2..45c021c68f 100644 --- a/packages/antd/test/__snapshots__/Array.test.tsx.snap +++ b/packages/antd/test/__snapshots__/Array.test.tsx.snap @@ -164,7 +164,7 @@ exports[`array fields arr...	{"should render text input for each array item": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{"hidden label": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "Creating entry file 1.5 secs": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "number field 0": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "Creating entry file 1.4 secs": {"run": "NONE", "test": "PASS", "fix": "PASS"}, "format date": {"run": "PASS"...	{}	{}	{"should render text input for each array item": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should concat nested arrays under `required` keyword": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "addFormat() was called twice": {"run": "...	{"passed_count": 1039, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should concat nested arrays under `required` keyword", "addFormat() was called twice", "should validate a simple array", "returns type=number, step=multipleOf, ma...	{"passed_count": 43, "failed_count": 0, "skipped_count": 0, "passed_tests": ["Creating entry file 1.4 secs", "string field with placeholder", "null field", "password field", "textarea field", "up/down field", "Building modules 1.3 mins", "Building modules 27.2 secs", "Building modules 59.5 secs", "format color", "array...	{"passed_count": 1036, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should concat nested arrays under `required` keyword", "addFormat() was called twice", "should validate a simple array", "returns type=number, step=multipleOf, ma...	null	ts	null
rjsf-team	react-jsonschema-form	3182	closed	fix(@rjsf/chakra-ui) Unify appearance of chakra-ui SelectWidget for single and multiple-choice	### Reasons for making this change fixes #3180 Changes: - In `SelectWidget`: use `Select` from `chakra-react-select` for both single- and multiple-choice select - In `SelectWidget` multiple-choice select: display label rather than value for selected items ### Checklist * [ ] **I'm updating documentatio...	{"label": "rjsf-team:main", "ref": "main", "sha": "6666b181ab548319042ef29a3df098e6da71b66a"}	[{"number": 3180, "title": "Unify appearance of chakra-ui SelectWidget for single and multiple-choice", "body": "### Prerequisites\n\n- [X] I have read the [documentation](https://react-jsonschema-form.readthedocs.io/)\n\n### What theme are you using?\n\nchakra-ui\n\n### Is your feature request related to a problem? Pl...	diff --git a/CHANGELOG.md b/CHANGELOG.md index 045d73da29..9a3eaee7aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,7 +24,9 @@ should change the heading of the (upcoming) version to include a major version b - Make label generation consistent with other themes by refactoring the code into the `FieldTemplate` ins...	diff --git a/packages/chakra-ui/test/Form.test.tsx b/packages/chakra-ui/test/Form.test.tsx index 720cea6aa0..82bf967e44 100644 --- a/packages/chakra-ui/test/Form.test.tsx +++ b/packages/chakra-ui/test/Form.test.tsx @@ -183,15 +183,111 @@ describe("single fields", () => { .toJSON(); expect(tree).toMatchSnaps...	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should fill array with additional items schema when items is empty": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should allow com...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should set attr action of form": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should throw when more than one wildcard is present": {"run": ...	{}	{}	{"should concat nested arrays under `required` keyword": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "addFormat() was called twice": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should fill array with additional items schema when items is empty": {"run": "PASS", "test": "NONE", "fix": "PASS"}, "should allow com...	{"passed_count": 1038, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "addFormat() was called twice", "should validate a simple...	{"passed_count": 692, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should validate a simple array", "should handle an empty string change event with custom ui:emptyValue", "should throw when more than one wildcard is present", "[f...	{"passed_count": 1038, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "returns type=number, step=multipleOf, max=maximum when schema has integer type, multipleOf and maximum", "addFormat() was called twice", "should validate a simple...	null	ts	null
rjsf-team	react-jsonschema-form	1476	closed	Rewrite mergeSchemas to fix schema dependencies merging	### Reasons for making this change Fixes #998. This makes sure that when dependencies are merged with the main schema, only arrays under the key `required` are merged. Other arrays are overwritten. With this PR, `mergeSchemas` uses lodash's `union` operator to merge required arrays, so that the arrays do not have...	{"label": "rjsf-team:master", "ref": "master", "sha": "5d167ac44fab18b4c36af643207828ca1876717c"}	[{"number": 998, "title": "Schema Dependencies Merged Incorrectly", "body": "### Prerequisites\r\n\r\n- [x] I have read the [documentation](https://github.com/mozilla-services/react-jsonschema-form/blob/master/README.md#readme);\r\n- [x] In the case of a bug report, I understand that providing a [SSCCE](http://sscce.or...	diff --git a/src/utils.js b/src/utils.js index 8cc52f58c5..259d64574b 100644 --- a/src/utils.js +++ b/src/utils.js @@ -2,6 +2,7 @@ import React from "react"; import * as ReactIs from "react-is"; import fill from "core-js/library/fn/array/fill"; import validateFormData, { isValid } from "./validate"; +import { union ...	diff --git a/test/Form_test.js b/test/Form_test.js index c04793cd2d..cf52395a58 100644 --- a/test/Form_test.js +++ b/test/Form_test.js @@ -2291,7 +2291,44 @@ describeRepeated("Form common", createFormComponent => { }); }); - describe("Dependency defaults", () => { + describe("Dependencies", () => { + it(...	{"shouldn't mutate the provided objects": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should recursively merge File objects": {"run": "PASS", "test": "FAIL", "fix": "PASS"}, "should not concat arrays": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should concat arrays under 'required' keyword when one of the sc...	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a file field": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should fill array with additional items schema when items is empty": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should validate a simple a...	{"shouldn't mutate the provided objects": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should recursively merge File objects": {"run": "PASS", "test": "FAIL", "fix": "PASS"}, "should not concat arrays": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should concat arrays under 'required' keyword when one of the sc...	{}	{}	{"passed_count": 686, "failed_count": 2, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should fill array with additional items schema when items is empty", "should validate a simple array", "should set attr action of form", "should throw when more th...	{"passed_count": 681, "failed_count": 21, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should fill array with additional items schema when items is empty", "should validate a simple array", "should set attr action of form", "should throw when more t...	{"passed_count": 695, "failed_count": 2, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should render a file field", "should fill array with additional items schema when items is empty", "should validate a simple array", "should set attr action of form", "should throw when more th...	null	ts	null
rjsf-team	react-jsonschema-form	1292	closed	Default type to `object` if undefined	### Reasons for making this change Fixes #1265 Added tests and confirmed working on the local test app: http://localhost:8080/#eyJmb3JtRGF0YSI6e30sInNjaGVtYSI6eyJwcm9wZXJ0aWVzIjp7ImEiOnsidHlwZSI6InN0cmluZyJ9fX0sInVpU2NoZW1hIjp7fX0= ### Checklist * [ ] I'm updating documentation - [ ] I've [checked the...	{"label": "rjsf-team:master", "ref": "master", "sha": "67d17dd06f5e38180b7c80ef78dbacc359cc81f4"}	[{"number": 1265, "title": "Default type to `object` if undefined", "body": "### Prerequisites\r\n\r\n- [x] I have read the [documentation](https://react-jsonschema-form.readthedocs.io/);\r\n- [x] In the case of a bug report, I understand that providing a [SSCCE](http://sscce.org/) example is tremendously useful to the...	diff --git a/src/utils.js b/src/utils.js index 22f08e1863..cf9600d5f4 100644 --- a/src/utils.js +++ b/src/utils.js @@ -76,6 +76,10 @@ export function getSchemaType(schema) { return "string"; } + if (!type && (schema.properties \|\| schema.additionalProperties)) { + return "object"; + } + if (type instan...	diff --git a/test/utils_test.js b/test/utils_test.js index 5acfcc229d..8b69e58b22 100644 --- a/test/utils_test.js +++ b/test/utils_test.js @@ -1544,11 +1544,22 @@ describe("utils", () => { schema: { type: ["integer", "null"] }, expected: "integer", }, + { + schema: { properties: {} ...	{"should correctly guess the type of a schema": {"run": "PASS", "test": "FAIL", "fix": "PASS"}}	{"should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should fill array with additional items schema when items is empty": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should validate a simple array": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should set attr action...	{"should correctly guess the type of a schema": {"run": "PASS", "test": "FAIL", "fix": "PASS"}}	{}	{}	{"passed_count": 607, "failed_count": 7, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should fill array with additional items schema when items is empty", "should validate a simple array", "should set attr action of form", "should throw when more than one wildcard is present", "...	{"passed_count": 606, "failed_count": 9, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should fill array with additional items schema when items is empty", "should validate a simple array", "should set attr action of form", "should throw when more than one wildcard is present", "...	{"passed_count": 607, "failed_count": 7, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should fill array with additional items schema when items is empty", "should validate a simple array", "should set attr action of form", "should throw when more than one wildcard is present", "...	null	ts	null
rjsf-team	react-jsonschema-form	476	closed	Fix #471: Drop default value initialization at the widget level.	Implements simple solution suggested by @crumblix in https://github.com/mozilla-services/react-jsonschema-form/issues/471#issuecomment-279902263 Deployed to [gh-pages](https://mozilla-services.github.io/react-jsonschema-form/) for easier testing. r=? @crumblix	{"label": "rjsf-team:master", "ref": "master", "sha": "4b6fe72e7cd85e06b35c4e9aa2bf0259c46cfa2c"}	[{"number": 471, "title": "setting default value for the string input refills the field when emptied up", "body": "As is shown below from the playground page.\r\n![bug](https://cloud.githubusercontent.com/assets/1630378/22921510/634f1912-f2dd-11e6-8517-c6d468801a1d.gif)\r\n\r\nIs this a desired behaviour? If so, is the...	diff --git a/playground/app.js b/playground/app.js index e3b25acab1..770599e924 100644 --- a/playground/app.js +++ b/playground/app.js @@ -362,6 +362,7 @@ class App extends Component { uiSchema={uiSchema} formData={formData} onChange={this.onFormDataChange} + on...	diff --git a/test/ArrayField_test.js b/test/ArrayField_test.js index c71b495474..5d67e6029b 100644 --- a/test/ArrayField_test.js +++ b/test/ArrayField_test.js @@ -111,6 +111,15 @@ describe("ArrayField", () => { .to.have.length.of(1); }); + it("should mark a non-null array item widget as required", ()...	{"should not set default when a text field is cleared": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should handle cleared field values in the array": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should mark non-null item widgets as required": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should mark a non-n...	{"should render empty option with placeholder text": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render text input for each array item": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should focus on alt-date-time input": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should validate a simple array": {"...	{"should not set default when a text field is cleared": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should handle cleared field values in the array": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should mark non-null item widgets as required": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should mark a non-n...	{}	{}	{"passed_count": 379, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should validate a simple array", "should set attr action of form", "should throw when more than one wildcard is present", "should render a root custom widget", "should render customized AltDate...	{"passed_count": 379, "failed_count": 13, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should validate a simple array", "should set attr action of form", "should throw when more than one wildcard is present", "should render a root custom widget", "should render customized AltDat...	{"passed_count": 383, "failed_count": 5, "skipped_count": 0, "passed_tests": ["should render text input for each array item", "should validate a simple array", "should set attr action of form", "should throw when more than one wildcard is present", "should render a root custom widget", "should render customized AltDate...	null	ts	null
rjsf-team	react-jsonschema-form	70	closed	Added shallow comparison checks to stateful components.	Fixes #54. @aduth, @magopian: could you please check this branch and see if it solves (or improves) the performance issue you're encountering? Thanks!	{"label": "rjsf-team:master", "ref": "master", "sha": "714e3f467d9d2ea50dbebf651da01a30af5ad3df"}	[{"number": 54, "title": "Performance optimizations", "body": "Loving this component so far! However, in my own usage, and even in the demo site, there's a noticeable lag when attempting to enter text into fields at a reasonable typing speed. Enabling the \"trace react updates\" option in Chrome [React Developer Tools]...	diff --git a/dist/react-jsonschema-form.js b/dist/react-jsonschema-form.js index b316282577..6cf24b5a9e 100644 --- a/dist/react-jsonschema-form.js +++ b/dist/react-jsonschema-form.js @@ -1,4 +1,10 @@ -!function(e,t){"object"==typeof exports&&"object"==typeof module?module.exports=t(require("react")):"function"==typeof ...	diff --git a/test/ArrayField_test.js b/test/ArrayField_test.js index be026e58fe..2493d6cd5a 100644 --- a/test/ArrayField_test.js +++ b/test/ArrayField_test.js @@ -1,7 +1,7 @@ import { expect } from "chai"; import { Simulate } from "react-addons-test-utils"; -import { createComponent } from "./test_utils"; +import {...	{"should detect diffing props": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should handle equivalent function prop": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should not render if next props are equivalent": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should not render if next formData are equivalent":...	{"should render a select widget with multiple attribute": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should call provided change handler on form state change": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should fill field with data": {"run": "PASS", "test": "PASS", "fix": "PASS"}, "should render a select wid...	{"should detect diffing props": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should handle equivalent function prop": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should not render if next props are equivalent": {"run": "NONE", "test": "FAIL", "fix": "PASS"}, "should not render if next formData are equivalent":...	{}	{}	{"passed_count": 93, "failed_count": 0, "skipped_count": 0, "passed_tests": ["should render a select widget with multiple attribute", "should render a select widget with a label", "should accept a uiSchema object", "should use a single schema definition reference", "should override the first object with the values from...	{"passed_count": 93, "failed_count": 20, "skipped_count": 0, "passed_tests": ["should render a select widget with multiple attribute", "should render a select widget with a label", "should accept a uiSchema object", "should use a single schema definition reference", "should override the first object with the values fro...	{"passed_count": 99, "failed_count": 0, "skipped_count": 0, "passed_tests": ["should render a select widget with multiple attribute", "should render a select widget with a label", "should accept a uiSchema object", "should use a single schema definition reference", "should override the first object with the values from...	null	ts	null

Subsets and Splits

No community queries yet

The top public SQL queries from the community will appear here once available.