Akarshan Biswas commited on
Commit
b4969ff
·
1 Parent(s): f7995cb

SYCL: disable faulty fp16 exp kernel (llama/14395)

Browse files

* SYCL: disable faulty fp16 CPU exponent for now

* Revert "SYCL: disable faulty fp16 CPU exponent for now"

This reverts commit ed0aab1ec31b4eb4b0f275dd7acd41d96a375202.

* SYCL: disable faulty fp16 CPU exponent for now

* Fix logic of disabling exponent kernel

Files changed (1) hide show
  1. ggml/src/ggml-sycl/ggml-sycl.cpp +3 -1
ggml/src/ggml-sycl/ggml-sycl.cpp CHANGED
@@ -4215,7 +4215,6 @@ static bool ggml_backend_sycl_device_supports_op(ggml_backend_dev_t dev, const g
4215
  case GGML_UNARY_OP_GELU_QUICK:
4216
  case GGML_UNARY_OP_GELU_ERF:
4217
  case GGML_UNARY_OP_TANH:
4218
- case GGML_UNARY_OP_EXP:
4219
  case GGML_UNARY_OP_SGN:
4220
  case GGML_UNARY_OP_ABS:
4221
  case GGML_UNARY_OP_ELU:
@@ -4224,6 +4223,9 @@ static bool ggml_backend_sycl_device_supports_op(ggml_backend_dev_t dev, const g
4224
  #else
4225
  return ggml_is_contiguous(op->src[0]) && (op->src[0]->type == GGML_TYPE_F32 && op->type == GGML_TYPE_F32) && (op->type == op->src[0]->type);
4226
  #endif
 
 
 
4227
  default:
4228
  return false;
4229
  }
 
4215
  case GGML_UNARY_OP_GELU_QUICK:
4216
  case GGML_UNARY_OP_GELU_ERF:
4217
  case GGML_UNARY_OP_TANH:
 
4218
  case GGML_UNARY_OP_SGN:
4219
  case GGML_UNARY_OP_ABS:
4220
  case GGML_UNARY_OP_ELU:
 
4223
  #else
4224
  return ggml_is_contiguous(op->src[0]) && (op->src[0]->type == GGML_TYPE_F32 && op->type == GGML_TYPE_F32) && (op->type == op->src[0]->type);
4225
  #endif
4226
+ case GGML_UNARY_OP_EXP:
4227
+ // Disable FP16 until we find out the root cause of failing fp16 sycl::exp
4228
+ return ggml_is_contiguous(op->src[0]) && (op->type == op->src[0]->type) && op->src[0]->type == GGML_TYPE_F32;
4229
  default:
4230
  return false;
4231
  }