danbev commited on
Commit
3c1d9fa
·
unverified ·
1 Parent(s): a4fc5fb

ruby : omit test_build_options locally (#3132)

Browse files

This commit omits the test for `test_build_options` when run locally as
it currently fails on Linux and MacOS platforms.
`
The motivation for this change is that currently when running the tests
locally on a non-macOS platform the test fails with the following error:
```console
.F
========================================================================
Failure: test_build_options(TestPackage):
<["ACCELERATE_FRAMEWORK",
"CMAKE_OSX_ARCHITECTURES",
"CMAKE_OSX_SYSROOT",
"FOUNDATION_LIBRARY",
"METALKIT_FRAMEWORK",
"METAL_FRAMEWORK"]> was expected to be empty.
/home/danbev/work/ai/whisper.cpp/bindings/ruby/tests/test_package.rb:43:in `test_build_options'
40: options = BuildOptions::Options.new
41: assert_empty options.missing_options
42: unless ENV["CI"]
=> 43: assert_empty options.extra_options
44: end
45: end
46: end
========================================================================
```

bindings/ruby/tests/test_package.rb CHANGED
@@ -37,6 +37,11 @@ class TestPackage < TestBase
37
  end
38
 
39
  def test_build_options
 
 
 
 
 
40
  options = BuildOptions::Options.new
41
  assert_empty options.missing_options
42
  unless ENV["CI"]
 
37
  end
38
 
39
  def test_build_options
40
+ # This test is disabled as it currently fails when run locally on macOS and
41
+ # Linux. We need to find a good way to handle the situation with build
42
+ # options which varies between platforms.
43
+ # Refs: https://github.com/ggml-org/whisper.cpp/pull/3132
44
+ omit "Temporarily disabled locally as this test currently fails when run locally" unless ENV["CI"]
45
  options = BuildOptions::Options.new
46
  assert_empty options.missing_options
47
  unless ENV["CI"]