`max_nb_epochs` not effective in master branch
Hi,
I think this might be an easy one to fix. I'm using the bleeding edge version from master with pytorch 1.3.
Trainer(max_nb_epochs=...) does not limit the max epochs in training at the moment. See doc
I think this is due to the following code and default setting:
https://github.com/williamFalcon/pytorch-lightning/blob/c32f2b91164abe309dd8456a16c01e9c35748bff/pytorch_lightning/trainer/trainer.py#L160-L164
But max_epochs has default set to 1000:
https://github.com/williamFalcon/pytorch-lightning/blob/c32f2b91164abe309dd8456a16c01e9c35748bff/pytorch_lightning/trainer/trainer.py#L75
Therefore by default if you only set max_nb_epochs=, the following is never called. Hence max_epochs will continue to be 1000.
https://github.com/williamFalcon/pytorch-lightning/blob/c32f2b91164abe309dd8456a16c01e9c35748bff/pytorch_lightning/trainer/trainer.py#L163-L164
This logic probably needs some enhancement, or let just one of these max epoch parameters drive training. Open to suggestions and happy to get a PR going based on what's decided.
Thanks.