What the NeptuneLogger records as params or properties
❓ Questions and Help

What is your question?
Currently, NeptuneLogger seems to be logging property what is passed as a hparams.

  
    
      pytorch-lightning/pytorch_lightning/loggers/neptune.py
    
    
         Line 233
      in
      c3cf33d
    
  
  
    

        
          
           def log_hyperparams(self, params: Union[Dict[str, Any], Namespace]) -> None: 
        
    
  


    @rank_zero_only
    def log_hyperparams(self, params: Union[Dict[str, Any], Namespace]) -> None:
        params = self._convert_params(params)
        params = self._flatten_dict(params)
        for key, val in params.items():
            self.experiment.set_property(f'param__{key}', val)

But neptune-client has already logged the hparams that were passed to it when it did the project.create_experiment. So the current implementation is trying to log hparams twice, in different ways.
Now I am trying to log a large number of hparams using hydra.
And it doesn't take much time to log the hparams during project.create_experiment, but it takes a long time to repeat the set_property in log_hyperparams loop.
So I am rewriting and running as follows, but there is no inconvenience
Is there a problem with changing it in this way? Also, is there any chance that this will be the default?
    @rank_zero_only
    def log_hyperparams(self, params: Union[Dict[str, Any], Namespace]) -> None:
        pass

What's your environment?

OS: [Linux]
Packaging [pip]
Version [0.7.6]